Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback when the dialog has been dismissed #33

Closed
doyonghoon opened this issue Mar 26, 2015 · 5 comments
Closed

Callback when the dialog has been dismissed #33

doyonghoon opened this issue Mar 26, 2015 · 5 comments
Milestone
v1.3

Comments

@doyonghoon
Copy link
Contributor

As Ordinary Dialog does, DialogPlus seems like to have the listener that notifies the user when DialogPlus dismisses. mind if I push a pull request for this issue and review for my code? thanks.
@orhanobut
Copy link
Owner

@doyonghoon Of course you can, It will be good to have it.

@doyonghoon
Copy link
Contributor Author

@orhanobut thanks for quick reply. I just tried to push a pull request for this issue, I encountered an error. here is the message.
fatal: unable to access 'https://github.com/orhanobut/dialogplus.git/': The requested URL returned error: 403

To solve this problem, i think that you may add me as a contributor or something in this project. please let me know if i am missing something.

@orhanobut
Copy link
Owner

To contribute, you need to fork the project and then you can push it to the your origin. then you can create a pull request from that point.

@doyonghoon
Copy link
Contributor Author

aha, got it. thanks.

@orhanobut orhanobut added this to the v1.3 milestone Mar 27, 2015
@doyonghoon
Copy link
Contributor Author

solved issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
2 participants
@orhanobut @doyonghoon