New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducing list of apps to share in Lolipop #35
Conversation
@orhanobut mind that the feature is not completed yet, but this is just a prototype. I will add comments on every changes to let you understand more clearly. Also, I will update what tasks are remaining to complete this feature later. thanks. |
@doyonghoon sure, we can go through PR together |
/** | ||
* Max width of the whole drawer layout | ||
*/ | ||
private int mMaxWidth; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convention for library is not using m prefix for variable names. i.e. writing maxWidth instead of mMaxWidth makes sense. All fields should be renamed in this class then
@doyonghoon I haven't checked the code but did you find any solution for the getNestedScrollAxes()? Apparently this feature will be very good |
@orhanobut no, unfortunately there's no alternative way found to perform the same method that |
no longer valid. |
This pull request will resolve the issue #26.
The changes may not be clear, this is just a prototype that focuses on reproducing list of apps to share in Lolipop. The options to enable it in
Dialog Plus Sample
are that checkingList Holder
,Show fixed header
. After that, just clickBOTTOM
button.Remaining tasks
m
prefix.DimmedListHolder
, the meaning of its name is vague.