Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducing list of apps to share in Lolipop #35

Closed
wants to merge 8 commits into from

Conversation

doyonghoon
Copy link
Contributor

This pull request will resolve the issue #26.
The changes may not be clear, this is just a prototype that focuses on reproducing list of apps to share in Lolipop. The options to enable it in Dialog Plus Sample are that checking List Holder, Show fixed header. After that, just click BOTTOM button.

Remaining tasks

  • alter global variables as a plain name without m prefix.
  • support backwards compatibility, currently only runnable on api >= 21.
  • give an intuitive name to the DimmedListHolder, the meaning of its name is vague.
  • add comments on related changes that play a pivotal role in presenting list of apps to share like Lolipop.

@doyonghoon
Copy link
Contributor Author

@orhanobut mind that the feature is not completed yet, but this is just a prototype. I will add comments on every changes to let you understand more clearly. Also, I will update what tasks are remaining to complete this feature later. thanks.

@orhanobut
Copy link
Owner

@doyonghoon sure, we can go through PR together

@doyonghoon doyonghoon changed the title Dimmed holder Reproducing list of apps to share in Lolipop Mar 30, 2015
/**
* Max width of the whole drawer layout
*/
private int mMaxWidth;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convention for library is not using m prefix for variable names. i.e. writing maxWidth instead of mMaxWidth makes sense. All fields should be renamed in this class then

@orhanobut
Copy link
Owner

@doyonghoon I haven't checked the code but did you find any solution for the getNestedScrollAxes()? Apparently this feature will be very good

@doyonghoon
Copy link
Contributor Author

@orhanobut no, unfortunately there's no alternative way found to perform the same method that getNestedScrollAxes() does..

@orhanobut
Copy link
Owner

no longer valid.

@orhanobut orhanobut closed this Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants