Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be nice to bundle the upstream CoreDNS version into the k8s-gateway release? #98

Open
mstoetzer opened this issue May 23, 2022 · 6 comments

Comments

@mstoetzer
Copy link

Something like <CoreDNS_UPSTREAM>-<Plugin_VERSION> e.g. image: quay.io/oriedge/k8s_gateway:1.9.1-0.3.0

@networkop
Copy link
Collaborator

yeah, I think this is possible. I've never seen this pattern before though. Any other plugins that implement this?

@mstoetzer
Copy link
Author

mstoetzer commented May 23, 2022

According to https://semver.org/ the CoreDNS version can be interpreted as build version / build number or metadata. Some discussion on this and this

The plus "+" sign that indicates metadata can't be used in Docker tags

@networkop
Copy link
Collaborator

We already do that for the binary itself, so it's visible using the version flag

caddy.AppVersion = fmt.Sprintf("%s+k8s_gateway-%s", coremain.CoreVersion, pluginVersion)

Do you want this only for the image tag?

@mstoetzer
Copy link
Author

My idea was to use that version in the image tag. I just wanted to trigger some discussion about that :)

@networkop
Copy link
Collaborator

I think it makes sense. Obv, we won't be building the same plugin version for different upstream coredns versions, but we can add an extra tag to an existing image for extra visibility.

@Ornias1993
Copy link

Double version is a hell to work with when you update containers using tools like renovate.
It works and can be made to work, but needless double versioning is usually more than a chore than a benefid imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants