Code observations were fixed

client/src/main/java/com/orientechnologies/orient/client/remote/OStorageRemote.java

@@ -82,7 +82,6 @@
 import java.util.concurrent.Callable;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
 import java.util.concurrent.atomic.AtomicInteger;
 
 /**
@@ -977,12 +976,11 @@ public void setDefaultClusterId(int defaultClusterId) {
     this.defaultClusterId = defaultClusterId;
   }
 
-  public int addCluster(final String iClusterName, boolean forceListBased, final Object... iArguments) {
-    return addCluster(iClusterName, -1, forceListBased, iArguments);
+  public int addCluster(final String iClusterName, final Object... iArguments) {
+    return addCluster(iClusterName, -1, iArguments);
   }
 
-  public int addCluster(final String iClusterName, final int iRequestedId, final boolean forceListBased,
-      final Object... iParameters) {
+  public int addCluster(final String iClusterName, final int iRequestedId, final Object... iParameters) {
     OAddClusterRequest request = new OAddClusterRequest(iRequestedId, iClusterName);
     OAddClusterResponse response = networkOperationNoRetry(request, "Error on add new cluster");
     addNewClusterToConfiguration(response.getClusterId(), iClusterName);

core/src/main/java/com/orientechnologies/orient/core/db/document/ODatabaseDocumentAbstract.java

@@ -56,7 +56,6 @@
 import com.orientechnologies.orient.core.metadata.OMetadata;
 import com.orientechnologies.orient.core.metadata.OMetadataDefault;
 import com.orientechnologies.orient.core.metadata.schema.OClass;
-import com.orientechnologies.orient.core.metadata.schema.OImmutableClass;
 import com.orientechnologies.orient.core.metadata.schema.OSchema;
 import com.orientechnologies.orient.core.metadata.schema.OSchemaProxy;
 import com.orientechnologies.orient.core.metadata.security.*;
@@ -69,9 +68,7 @@
 import com.orientechnologies.orient.core.serialization.serializer.record.ORecordSerializerFactory;
 import com.orientechnologies.orient.core.sql.OCommandSQL;
 import com.orientechnologies.orient.core.sql.executor.OResultSet;
-import com.orientechnologies.orient.core.sql.parser.OLocalResultSetLifecycleDecorator;
 import com.orientechnologies.orient.core.storage.*;
-import com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage;
 import com.orientechnologies.orient.core.storage.impl.local.OFreezableStorageComponent;
 import com.orientechnologies.orient.core.storage.impl.local.OMicroTransaction;
 import com.orientechnologies.orient.core.storage.impl.local.paginated.OOfflineClusterException;
@@ -922,13 +919,13 @@ public boolean isClosed() {
   @Override
   public int addCluster(final String iClusterName, final Object... iParameters) {
     checkIfActive();
-    return getStorage().addCluster(iClusterName, false, iParameters);
+    return getStorage().addCluster(iClusterName, iParameters);
   }
 
   @Override
   public int addCluster(final String iClusterName, final int iRequestedId, final Object... iParameters) {
     checkIfActive();
-    return getStorage().addCluster(iClusterName, iRequestedId, false, iParameters);
+    return getStorage().addCluster(iClusterName, iRequestedId, iParameters);
   }
 
   @Override

core/src/main/java/com/orientechnologies/orient/core/index/sbtree/local/OSBTree.java

@@ -440,8 +440,6 @@ public void close(boolean flush) {
         if (nullPointerSupport)
           readCache.closeFile(nullBucketFileId, flush, writeCache);
 
-      } catch (IOException e) {
-        throw OException.wrapException(new OSBTreeException("Error during close of index " + getName(), this), e);
       } finally {
         releaseExclusiveLock();
       }

core/src/main/java/com/orientechnologies/orient/core/index/sbtreebonsai/local/OSBTreeBonsaiLocal.java

@@ -295,8 +295,6 @@ public void close(boolean flush) {
       Lock lock = FILE_LOCK_MANAGER.acquireExclusiveLock(fileId);
       try {
         readCache.closeFile(fileId, flush, writeCache);
-      } catch (IOException e) {
-        throw OException.wrapException(new OSBTreeBonsaiLocalException("Error during close of index " + getName(), this), e);
       } finally {
         lock.unlock();
       }

core/src/main/java/com/orientechnologies/orient/core/storage/OAutoshardedStorage.java

@@ -42,8 +42,6 @@ public interface OAutoshardedStorage {
 
   /**
    * Check if the distributed need to run only as local env
-   *
-   * @return
    */
   boolean isLocalEnv();
 }

core/src/main/java/com/orientechnologies/orient/core/storage/OCluster.java

@@ -28,7 +28,7 @@
 public interface OCluster {
 
   enum ATTRIBUTES {
-    NAME, USE_WAL, RECORD_GROW_FACTOR, RECORD_OVERFLOW_GROW_FACTOR, CONFLICTSTRATEGY, STATUS, ENCRYPTION
+    NAME, RECORD_GROW_FACTOR, RECORD_OVERFLOW_GROW_FACTOR, CONFLICTSTRATEGY, STATUS, ENCRYPTION
   }
 
   void configure(OStorage iStorage, int iId, String iClusterName, Object... iParameters) throws IOException;
@@ -54,7 +54,6 @@ enum ATTRIBUTES {
   /**
    * Truncates the cluster content. All the entries will be removed.
    *
-   * @throws IOException
    */
   void truncate() throws IOException;
 
@@ -64,8 +63,6 @@ enum ATTRIBUTES {
    * @param recordType the type of record of which allocate the position.
    *
    * @return the allocated position.
-   *
-   * @throws IOException
    */
   OPhysicalPosition allocatePosition(byte recordType) throws IOException;
 
@@ -78,8 +75,6 @@ enum ATTRIBUTES {
    * @param allocatedPosition the eventual allocated position or null if there is no allocated position.
    *
    * @return the position where the record si created.
-   *
-   * @throws IOException
    */
   OPhysicalPosition createRecord(byte[] content, int recordVersion, byte recordType, OPhysicalPosition allocatedPosition)
       throws IOException;
@@ -101,8 +96,6 @@ OPhysicalPosition createRecord(byte[] content, int recordVersion, byte recordTyp
 
   /**
    * Fills and return the PhysicalPosition object received as parameter with the physical position of logical record iPosition
-   *
-   * @throws IOException
    */
   OPhysicalPosition getPhysicalPosition(OPhysicalPosition iPPosition) throws IOException;
 
@@ -124,8 +117,6 @@ OPhysicalPosition createRecord(byte[] content, int recordVersion, byte recordTyp
 
   /**
    * Returns the size of the records contained in the cluster in bytes.
-   *
-   * @return
    */
   long getRecordsSize() throws IOException;
 

core/src/main/java/com/orientechnologies/orient/core/storage/OClusterEntryIterator.java

@@ -47,6 +47,7 @@ public OClusterEntryIterator(final OCluster iCluster) {
     positionsIndex = -1;
   }
 
+  @Override
   public boolean hasNext() {
     if (min == ORID.CLUSTER_POS_INVALID)
       return false;
@@ -57,6 +58,7 @@ public boolean hasNext() {
     return positionsToProcess.length != 0;
   }
 
+  @Override
   public OPhysicalPosition next() {
     try {
       if (positionsIndex == -1) {
@@ -81,6 +83,7 @@ public OPhysicalPosition next() {
     }
   }
 
+  @Override
   public void remove() {
     throw new UnsupportedOperationException("remove");
   }

core/src/main/java/com/orientechnologies/orient/core/storage/OPhysicalPosition.java

@@ -29,7 +29,7 @@
 import java.io.ObjectOutput;
 
 public class OPhysicalPosition implements OSerializableStream, Externalizable {
-  public static final int binarySize    = OBinaryProtocol.SIZE_LONG + OBinaryProtocol.SIZE_BYTE + OBinaryProtocol.SIZE_INT
+  private static final int binarySize = OBinaryProtocol.SIZE_LONG + OBinaryProtocol.SIZE_BYTE + OBinaryProtocol.SIZE_INT
       + OBinaryProtocol.SIZE_INT;
   public long             clusterPosition;
   public byte             recordType;
@@ -52,11 +52,7 @@ public OPhysicalPosition(final long iClusterPosition, final int iVersion) {
     recordVersion = iVersion;
   }
 
-  public static int binarySize() {
-    return binarySize;
-  }
-
-  public void copyTo(final OPhysicalPosition iDest) {
+  private void copyTo(final OPhysicalPosition iDest) {
     iDest.clusterPosition = clusterPosition;
     iDest.recordType = recordType;
     iDest.recordVersion = recordVersion;
@@ -72,6 +68,7 @@ public String toString() {
     return "rid(?:" + clusterPosition + ") record(type:" + recordType + " size:" + recordSize + " v:" + recordVersion + ")";
   }
 
+  @Override
   public OSerializableStream fromStream(final byte[] iStream) throws OSerializationException {
     int pos = 0;
 
@@ -89,8 +86,9 @@ public OSerializableStream fromStream(final byte[] iStream) throws OSerializatio
     return this;
   }
 
+  @Override
   public byte[] toStream() throws OSerializationException {
-    final byte[] buffer = new byte[binarySize()];
+    final byte[] buffer = new byte[binarySize];
     int pos = 0;
 
     OBinaryProtocol.long2bytes(clusterPosition, buffer, pos);
@@ -126,13 +124,15 @@ public int hashCode() {
     return result;
   }
 
+  @Override
   public void writeExternal(final ObjectOutput out) throws IOException {
     out.writeLong(clusterPosition);
     out.writeByte(recordType);
     out.writeInt(recordSize);
     out.writeInt(recordVersion);
   }
 
+  @Override
   public void readExternal(final ObjectInput in) throws IOException, ClassNotFoundException {
     clusterPosition = in.readLong();
     recordType = in.readByte();

core/src/main/java/com/orientechnologies/orient/core/storage/ORawBuffer.java

@@ -48,21 +48,21 @@ public ORawBuffer(final byte[] buffer, final int version, final byte recordType)
 
   /**
    * Creates a new object by the record received.
-   * 
-   * @param iRecord
    */
   public ORawBuffer(final ORecord iRecord) {
     this.buffer = iRecord.toStream();
     this.version = iRecord.getVersion();
     this.recordType = ORecordInternal.getRecordType(iRecord);
   }
 
+  @Override
   public void readExternal(final ObjectInput iInput) throws IOException, ClassNotFoundException {
     super.readExternal(iInput);
     version = iInput.readInt();
     recordType = iInput.readByte();
   }
 
+  @Override
   public void writeExternal(final ObjectOutput iOutput) throws IOException {
     super.writeExternal(iOutput);
     iOutput.writeInt(version);

core/src/main/java/com/orientechnologies/orient/core/storage/OStorage.java

@@ -123,15 +123,14 @@ OStorageOperationResult<Integer> updateRecord(ORecordId iRecordId, boolean updat
    *
    * @param iClusterName name of the cluster
    */
-  int addCluster(String iClusterName, boolean forceListBased, Object... iParameters);
+  int addCluster(String iClusterName, Object... iParameters);
 
   /**
    * Add a new cluster into the storage.
-   *
-   * @param iClusterName name of the cluster
+   *  @param iClusterName name of the cluster
    * @param iRequestedId requested id of the cluster
    */
-  int addCluster(String iClusterName, int iRequestedId, boolean forceListBased, Object... iParameters);
+  int addCluster(String iClusterName, int iRequestedId, Object... iParameters);
 
   boolean dropCluster(String iClusterName, final boolean iTruncate);
 

core/src/main/java/com/orientechnologies/orient/core/storage/OStorageAbstract.java

@@ -25,8 +25,6 @@
 import com.orientechnologies.common.exception.OException;
 import com.orientechnologies.orient.core.Orient;
 import com.orientechnologies.orient.core.config.OStorageConfiguration;
-import com.orientechnologies.orient.core.db.OLiveQueryMonitor;
-import com.orientechnologies.orient.core.db.OLiveQueryResultListener;
 import com.orientechnologies.orient.core.db.record.OCurrentStorageComponentsFactory;
 import com.orientechnologies.orient.core.exception.OStorageException;
 import com.orientechnologies.orient.core.record.ORecordVersionHelper;
@@ -67,10 +65,10 @@ public abstract class OStorageAbstract implements OStorage, OSharedContainer {
   protected volatile OStorageConfiguration            configuration;
   protected volatile OCurrentStorageComponentsFactory componentsFactory;
   protected          String                           name;
-  protected          AtomicLong version = new AtomicLong();
+  private final      AtomicLong version = new AtomicLong();
   protected volatile STATUS     status  = STATUS.CLOSED;
 
-  protected final OSharedContainerImpl sharedContainer = new OSharedContainerImpl();
+  private final OSharedContainerImpl sharedContainer = new OSharedContainerImpl();
 
   public OStorageAbstract(final String name, final String iURL, final String mode) {
     this.name = normalizeName(name);
@@ -105,36 +103,45 @@ protected String normalizeName(String name) {
     }
   }
 
+  @Override
   public abstract OCluster getClusterByName(final String iClusterName);
 
+  @Override
   public OStorage getUnderlying() {
     return this;
   }
 
+  @Override
   public OStorageConfiguration getConfiguration() {
     return configuration;
   }
 
+  @Override
   public boolean isClosed() {
     return status == STATUS.CLOSED;
   }
 
+  @Override
   public boolean checkForRecordValidity(final OPhysicalPosition ppos) {
     return ppos != null && !ORecordVersionHelper.isTombstone(ppos.recordVersion);
   }
 
+  @Override
   public String getName() {
     return name;
   }
 
+  @Override
   public String getURL() {
     return url;
   }
 
+  @Override
   public void close() {
     close(false, false);
   }
 
+  @Override
   public void close(final boolean iForce, boolean onDelete) {
     sharedContainer.clearResources();
   }
@@ -157,14 +164,17 @@ public <T> T getResource(String iName, Callable<T> iCallback) {
   /**
    * Returns current storage's version as serial.
    */
+  @Override
   public long getVersion() {
     return version.get();
   }
 
+  @Override
   public boolean dropCluster(final String iClusterName, final boolean iTruncate) {
     return dropCluster(getClusterIdByName(iClusterName), iTruncate);
   }
 
+  @Override
   public long countRecords() {
     long tot = 0;
 
@@ -175,6 +185,7 @@ public long countRecords() {
     return tot;
   }
 
+  @Override
   public <V> V callInLock(final Callable<V> iCallable, final boolean iExclusiveLock) {
     stateLock.acquireReadLock();
     try {
@@ -195,6 +206,7 @@ public String toString() {
     return url != null ? url : "?";
   }
 
+  @Override
   public STATUS getStatus() {
     return status;
   }

core/src/main/java/com/orientechnologies/orient/core/storage/OStorageOperationResult.java

@@ -26,7 +26,6 @@
 import java.io.IOException;
 import java.io.ObjectInput;
 import java.io.ObjectOutput;
-import java.util.Arrays;
 
 /**
  * This class represent CRUD operation result RET is the actual result Stores addition information about command execution process