-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conversion of html generated by html-webpack-plugin #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Chieffo2021
requested changes
Feb 12, 2022
This comment was marked as resolved.
This comment was marked as resolved.
Chieffo2021
reviewed
Feb 17, 2022
e4153d7
to
5314f58
Compare
Chieffo2021
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #83
transform functional webpack config with AST
webpackConfigure
andchainWebpack
options could be defined as object or function invue.config.js
modulevue.temp.config.js
) to reconfightml-webpack-plugin
AST
FindWebpackConfigProperties
: initialize config options according to functionalwebpackConfigure
FindHtmlPluginChain
: parsechainWebpack
ChainWebpackTransformation
: generate a temporary file (vue.temp.config.js
) to reconfightml-webpack-plugin
FindHtmlConfigProperties
: reparsechainWebpack
and initialize options for html pluginhtml-webpack-plugin
is supportedvite-plugin-html
index.html
will be transformed. for example,<%= htmlWebpackPlugin.options.title %>
-><%= title %>
injectHtml
andminifyHtml
fromhtml-webpack-plugin
support these options:
Thank you for your review. I will add test use cases.