-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for Invalid Url #42
Comments
Correct, you are more than welcome to create a PR about it. |
Hey I want to work on this issue and new to opensource can u guide me for this. |
You can checkout our Contribute.md file here: https://github.com/origranot/url-shortener/blob/master/CONTRIBUTE.MD |
Currently, if you enter valid URL when the page is loaded, it works fine until it encounters an invalid URL. Once it encounters an invalid URL, it will display "The URL is invalid" although you enter a valid URL.
|
Hey @origranot after I pulled the latest release, every entered URL is getting an "invalid URL " error. Can you please once go through the latest merge which caused this issue? |
It is fixed. Do you want to work on a PR for this problem? |
Yes, I will create PR by today itself. |
@Amiyanshu-web Great! |
Currently, the app is shortening the URL provided by the user irrespective of being valid or invalid.
The URL should be verified before shortening it.
If URL does not exist "Invalid URL" message should be shown.
The text was updated successfully, but these errors were encountered: