Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Invalid Url #42

Closed
Amiyanshu-web opened this issue Oct 6, 2022 · 8 comments
Closed

Check for Invalid Url #42

Amiyanshu-web opened this issue Oct 6, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Amiyanshu-web
Copy link

Currently, the app is shortening the URL provided by the user irrespective of being valid or invalid.
The URL should be verified before shortening it.
If URL does not exist "Invalid URL" message should be shown.

@origranot
Copy link
Owner

Correct, you are more than welcome to create a PR about it.

@origranot origranot added the enhancement New feature or request label Oct 6, 2022
@Ayush-Kori
Copy link

Hey I want to work on this issue and new to opensource can u guide me for this.

@origranot
Copy link
Owner

Hey I want to work on this issue and new to opensource can u guide me for this.

You can checkout our Contribute.md file here: https://github.com/origranot/url-shortener/blob/master/CONTRIBUTE.MD
If you need further help let me know :)

@gcsandesh
Copy link

Currently, if you enter valid URL when the page is loaded, it works fine until it encounters an invalid URL. Once it encounters an invalid URL, it will display "The URL is invalid" although you enter a valid URL.

  1. On first load of page when the URL is valid:

image

  1. It will show valid URL if you continuously enter a valid URL (for now).
  2. When it encounters an invalid URL

image

  1. Now even though you enter any valid URL, it will be considered invalid (unless you reload the page).

image

@Amiyanshu-web
Copy link
Author

Hey @origranot after I pulled the latest release, every entered URL is getting an "invalid URL " error. Can you please once go through the latest merge which caused this issue?

@origranot
Copy link
Owner

Hey @origranot after I pulled the latest release, every entered URL is getting an "invalid URL " error. Can you please once go through the latest merge which caused this issue?

It is fixed. Do you want to work on a PR for this problem?

@origranot origranot added the help wanted Extra attention is needed label Oct 7, 2022
@Amiyanshu-web
Copy link
Author

Hey @origranot after I pulled the latest release, every entered URL is getting an "invalid URL " error. Can you please once go through the latest merge which caused this issue?

It is fixed. Do you want to work on a PR for this problem?

Yes, I will create PR by today itself.

@origranot
Copy link
Owner

@Amiyanshu-web Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants