Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic on CSPRNG error instead of returning Result #67

Closed
brycx opened this issue Mar 31, 2019 · 1 comment
Closed

Panic on CSPRNG error instead of returning Result #67

brycx opened this issue Mar 31, 2019 · 1 comment

Comments

@brycx
Copy link
Member

brycx commented Mar 31, 2019

All generate() functions should panic on an error that is returned by fill_bytes() or similar. Generating "non-faulty" random bytes is so important to security, that handling an error arising from this should not be left to the user.

Furthermore, using rand_os also chooses to use a blocking interface in most cases and so this will not be relevant to handle.
This was referenced Mar 31, 2019
Closed
Merged
@brycx
Copy link
Member Author

brycx commented Apr 3, 2019

Fixed in #69.

@brycx brycx closed this as completed Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brycx