Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateWithoutConstructor must be defined above all classes #54

Closed
3 tasks
mabar opened this issue Jan 27, 2023 · 2 comments
Closed
3 tasks

CreateWithoutConstructor must be defined above all classes #54

mabar opened this issue Jan 27, 2023 · 2 comments
Milestone

Comments

@mabar
Copy link
Member

mabar commented Jan 27, 2023

If parent object supports to be created without object mapper, child should not break this promise. Opposite applies as well. One object in hierarchy cannot request valdiation dependencies in constructor while other expects already valid values.

If any class, interface or trait defines __construct() and uses CreateWithoutConstructor:

  • Each class with __construct() must use CreateWithoutConstructor
  • Each trait with __construct() must use CreateWithoutConstructor
  • Each interface with __construct() must use CreateWithoutConstructor
@mabar
Copy link
Member Author

mabar commented Apr 27, 2023

Replaced by #65 as a superior solution

Attributes repeatability and overriding has to be solved independently for all cases

@mabar mabar closed this as completed Apr 27, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant