Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on Safari 9.1.1 on Mac #45

Closed
t1 opened this issue Jul 6, 2016 · 5 comments
Closed

Broken on Safari 9.1.1 on Mac #45

t1 opened this issue Jul 6, 2016 · 5 comments
Labels
Milestone

Comments

@t1
Copy link

t1 commented Jul 6, 2016

While it works fine on Chrome, it just doesn't load more on Safari. Not in the plunkr, nor in the echoes.

Looking at the other issues, you seem to be testing with Safari, too confused

@orizens
Copy link
Owner

orizens commented Jul 7, 2016

hi @t1
thanks for reporting.
for a bug fix - it seems like the "height" code (as well as other properties on the window) breaks the js flow and returns an error. This eventually breaks the calculations function.
a possible fix - is checking for

elem.hasOwnProperty('offsetHeight')

and then, perhaps use:

window.document.body.offsetHeight

this should be done for all window properties that are retrieved for calculations.

Good Reference

@t1
Copy link
Author

t1 commented Jul 7, 2016

@orizens: I'm quite new to js, and try to stick to things like Angular ;-) But you seem to know exactly what would have to be done. Do you think you will be able to find the time to do it? And maybe even can say, when this might be?

@freezing
Copy link

Hi, what's the status of this bug?
It's not working on iPhone as well.

This looks like a quickfix according to your answer.
Is the problem that elem[property] doesn't work on safari at all, or only if the elem is window?

It's nicer to have this fixed in the master branch because I believe most of us are using npm to install the dependencies and it gives us the compiled version, which is not very nice to fix.

@orizens
Copy link
Owner

orizens commented Aug 16, 2016

hi @freezing
bug is still opened. fix is not that simple but hope i will have time for it soon.

@orizens orizens added this to the 0.2 milestone Aug 24, 2016
@freezing
Copy link

Thanks a lot for fixing this. It's working well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants