Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As of 0.2.7, base-x no longer compiles with std as default #15

Closed
fasterthanlime opened this issue Nov 8, 2020 · 1 comment · Fixed by #17
Closed

As of 0.2.7, base-x no longer compiles with std as default #15

fasterthanlime opened this issue Nov 8, 2020 · 1 comment · Fixed by #17

Comments

@fasterthanlime
Copy link
Contributor

fasterthanlime commented Nov 8, 2020 •
edited

This line:

base-x-rs/src/lib.rs

Line 55 in 8f46fda

#[cfg(features = "std")]

Needs to be:

#[cfg(features = "std")]
fasterthanlime added a commit to fasterthanlime/base-x-rs that referenced this issue Nov 8, 2020
@fasterthanlime
Use 'std' feature by default
ce57ca6 
Closes OrKoN#15
@fasterthanlime fasterthanlime mentioned this issue Nov 8, 2020
Closed
fasterthanlime added a commit to fasterthanlime/base-x-rs that referenced this issue Nov 8, 2020
@fasterthanlime
Use cfg(feature), not cfg(features)
016912a 
Closes OrKoN#15
@fasterthanlime fasterthanlime mentioned this issue Nov 8, 2020
Merged
@OrKoN OrKoN closed this as completed in #17 Nov 8, 2020
@fasterthanlime
Copy link
Contributor Author

Thanks for the prompt merge + bump! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@fasterthanlime