Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom SSHAuthenticationMethod #28

Closed
waylybaye opened this issue Feb 20, 2023 · 5 comments
Closed

Support custom SSHAuthenticationMethod #28

waylybaye opened this issue Feb 20, 2023 · 5 comments
Assignees
@Joannis
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@waylybaye
Copy link
Contributor

I would like to suggest adding support for custom SSHAuthenticationMethod. Currently, I need to provide multiple authentication methods for one SSH connection, such as auto-attempting all available keys or implementing two-factor login. It would be great if SSHClient.connect could use NIOSSHClientUserAuthenticationDelegate as a generic parameter so that users can implement their own authentication logic.
@Joannis
Copy link
Member

Joannis commented Feb 20, 2023

I agree, thanks for the issue.

@Joannis Joannis self-assigned this Feb 20, 2023
@Joannis Joannis added enhancement New feature or request good first issue Good for newcomers labels Feb 20, 2023
@Joannis
Copy link
Member

Joannis commented Feb 20, 2023

Implemented to be merged bundled with #26

@waylybaye
Copy link
Contributor Author

Great news! I have tested the branch, and it works perfectly. However, I did encounter an issue when testing 2-factor login, as swift-nio-ssh currently does not support keyboard-interactive authentication. If I have the time, I will attempt to make a pull request to address this issue. Thank you for your efforts in developing this feature!

@Joannis
Copy link
Member

Joannis commented Feb 20, 2023

Sounds good! Let me know if you need any tips for that. I'm closely involved with NIOSSH as well, and can bring up the topic with cory this week.

@Joannis Joannis mentioned this issue Feb 20, 2023
Open
@Joannis
Copy link
Member

Joannis commented Feb 20, 2023

I'll close this one for now, in favour of #30

@Joannis Joannis closed this as completed Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joannis Joannis

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waylybaye @Joannis