Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML documentation missing while consuming package #30

Closed
Kritner opened this issue Dec 21, 2021 · 1 comment · Fixed by #31
Closed

XML documentation missing while consuming package #30

Kritner opened this issue Dec 21, 2021 · 1 comment · Fixed by #31
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Kritner
Copy link
Member

Kritner commented Dec 21, 2021

On mouse over:

image

vs viewing the code:

image

Assuming that I just need GenerateDocumentationFile within the csproj file based on https://stackoverflow.com/a/47118584/2312877
@Kritner Kritner added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 21, 2021
Kritner added a commit to Kritner/Orleans.SyncWork that referenced this issue Dec 22, 2021
@Kritner
Create XML documentation file for packing with NuGet
c0169bd 
* Closes OrleansContrib#30
* Adds missing XML comments that were showing up as warnings upon build
@Kritner Kritner mentioned this issue Dec 22, 2021
Merged
Kritner added a commit that referenced this issue Dec 22, 2021
@Kritner
Create XML documentation file for packing with NuGet (#31)
f9ab67d 
* Closes #30
* Adds missing XML comments that were showing up as warnings upon build after turning on xml generation
@Kritner
Copy link
Member Author

Kritner commented Dec 22, 2021

from the new package version: image

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create XML documentation file for packing with NuGet Kritner/Orleans.SyncWork
1 participant
@Kritner