Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional docstrings #5

Closed

Conversation

KasperDeBlieck
Copy link

Hi,

I created some docstrings for the util functions. It think it's a good first step to get familiar with the code base, and it might help others who are trying to do the same.
I only did those so far, because I wanted to get some feedback before investing to much time.

Of course, I'll probably get some stuff wrong along the way, so someone will have to spend some time on reviews as well.
Let me know if you want me to continue on the rest of the code.

Kind regards,
Kasper

info = engine.analyse(node.board(), multipv = 2, limit = limit)
global nps
÷ global nps
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@ornicar
Copy link
Owner

ornicar commented May 2, 2021

Thanks but this is just a generator script generating puzzles in the background, I don't think it deserves that level of attention.

Additionally it seems to me that most of the comments are superfluous and add very little meaning that the function name and types don't already convey.

@ornicar ornicar closed this May 2, 2021
@KasperDeBlieck KasperDeBlieck deleted the feature/docstrings_utils branch May 2, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants