Avoid 3-fold repetitions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Glad to see this fixed! I'll write a script to retroactively apply this filter to the puzzle database. |
kraktus
added a commit
to kraktus/lichess-puzzler
that referenced
this pull request
Sep 30, 2021
ornicar#9 Uses `fen` method which includes the move number, so positions are never equals. Found thanks to https://lichess.org/forum/lichess-feedback/cooked--in-2-puzzle. Run against the source game of the puzzle and v47 generate the faulty puzzle while v48 (this one) does not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 3e3377e for a clean diff
The transition to a class isn't really necessary but I thought it would be useful for this at first.