Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from position games should not use huffman encoding #4113

Closed
10 tasks done
niklasf opened this issue Mar 9, 2018 · 0 comments
Closed
10 tasks done

from position games should not use huffman encoding #4113

niklasf opened this issue Mar 9, 2018 · 0 comments
Labels
bug

Comments

@niklasf
Copy link
Member

niklasf commented Mar 9, 2018 •
edited by ornicar

At leats for direct challenges https://github.com/ornicar/lila/blob/master/modules/game/src/main/Game.scala#L643 can be standard. Review:

  • app/controllers/UserAnalysis.scala: lila.game.Game.make(
  • modules/challenge/src/main/Joiner.scala: val game = Game.make(
  • modules/importer/src/main/DataForm.scala: val dbGame = Game.make(
  • modules/lobby/src/main/Biter.scala: Game.make(
  • modules/lobby/src/main/Biter.scala: Game.make(
  • modules/pool/src/main/GameStarter.scala: ) = Game.make(
  • modules/round/src/main/Rematcher.scala: } yield Game.make(
  • modules/setup/src/main/AiConfig.scala: Game.make(
  • modules/simul/src/main/SimulApi.scala: game1 = Game.make(
  • modules/tournament/src/main/AutoPairing.scala: val game = Game.make(

Or maybe it's fixed via 4e82c37?
@niklasf niklasf added the bug label Mar 9, 2018
@ornicar ornicar closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ornicar @niklasf