Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase critical time warnings and customization #829

Closed
Unihedro opened this issue Aug 22, 2015 · 6 comments
Closed

Increase critical time warnings and customization #829

Unihedro opened this issue Aug 22, 2015 · 6 comments
Labels
improvement Small incremental improvement to an existing feature stale

Comments

@Unihedro
Copy link
Contributor

http://ja.lichess.org/forum/lichess-feedback/critical-time

@Vinvin20
Copy link
Contributor

IMHO, there should be 2 types of time warning : close to 0 and late on your opponent.
In 1+0 : I would want to be warn when I cross the 10 sec (1/6 of the time) "play fast !" and when I cross 5 sec (1/12 of the time) "time scramble !". 2nd type, when I have only 2/3 (or a value between 60% and 70%) the time of my opponent (example : 20 to 30 sec) : "Late !".

@Unihedro
Copy link
Contributor Author

Can perhaps reuse #609 (bd81e76) on setting.

@Unihedro Unihedro added good first issue Narrow in scope (but not necessarily easy) improvement Small incremental improvement to an existing feature and removed good first issue Narrow in scope (but not necessarily easy) labels Aug 23, 2015
@Vinvin20
Copy link
Contributor

Yes, yellow clock (and a small sound first time it happen) would be good for :

  • when I cross 5 sec (1/12 of the time)
    and
  • when I have only 2/3 (or a value between 60% and 70%) the time of my opponent

@Unihedro Unihedro added this to the Design & Customization milestone Oct 7, 2015
@TheCodeArtist
Copy link

TheCodeArtist commented Dec 1, 2017

These time limits/thresholds %s look arbitrary to me.
Also a few Qs before someone jumps into the implementation.

  • Should the limit values be customisable by the user to suit their preferences?
    • User can specify limits as absolute values or % values or either?
  • We need per-move warning counter?
  • time-left warning (lot sooner than the current time-left critical) counter?
  • what other time-limit warnings do players usually use/want/need?

@stale
Copy link

stale bot commented Dec 14, 2019

There has been no activity on this issue for 2 years. It will be automatically closed in 2 weeks.
If the issue is still relevant, please briefly explain (or remove the label). Feel free to reopen at any time.

@stale stale bot added the stale label Dec 14, 2019
@stale stale bot closed this as completed Dec 28, 2019
@boborbt
Copy link

boborbt commented Jul 13, 2020

I would totally love some more control on the critical time alerts. To keep things simple just a preference about when the critical time alert should fire would be a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Small incremental improvement to an existing feature stale
Projects
None yet
Development

No branches or pull requests

4 participants