Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game start notification sound and the move sound played at same time when starting a game on iPad #8993

Closed
timothyarmes opened this issue May 21, 2021 · 0 comments · Fixed by #8994
Closed

Game start notification sound and the move sound played at same time when starting a game on iPad #8993

timothyarmes opened this issue May 21, 2021 · 0 comments · Fixed by #8994
Labels
bug

Comments

@timothyarmes
Copy link
Contributor

Similar to issue #8852, the iPad doesn't play a sound unless there's a user interaction.

The fixes for #8852 enables the move sound, but the user's own first move is accompanied by the GenericNotification sound that should have been played when the game starts.
timothyarmes added a commit to timothyarmes/lila that referenced this issue May 21, 2021
@timothyarmes
Preload sounds when starting a game
b27bf18 
Fixes lichess-org#8993.

The iPad (along wither other devices) requires an interaction to play a sound.  By preloading the sounds Howler will do it's best to unlock them on an interaction before they're needed.
@timothyarmes timothyarmes mentioned this issue May 21, 2021
Merged
@timothyarmes timothyarmes changed the title First move Notification sound and move sound played at same time when starting a game on iPad Game start notification sound and the move sound played at same time when starting a game on iPad May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preload sounds when starting a game timothyarmes/lila
1 participant
@timothyarmes