Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking King then clicking Rook should not castle #943

Closed
hendley opened this issue Sep 11, 2015 · 4 comments
Closed

Clicking King then clicking Rook should not castle #943

hendley opened this issue Sep 11, 2015 · 4 comments
Labels
controversial improvement Small incremental improvement to an existing feature

Comments

@hendley
Copy link

hendley commented Sep 11, 2015

This is very unexpected and I have been burned by it many times.

There are many situations when I click / pick up my King to castle, then see that it is either bad to castle, or much better to move my rook, so I click / pick up my Rook instead, only to inadvertently castle!

I should only be able to castle by dragging my King to the destination square, or by clicking my King and then clicking the destination square.

@ornicar
Copy link
Collaborator

ornicar commented Sep 11, 2015

it's required for chess960.

@Happy0
Copy link
Contributor

Happy0 commented Sep 11, 2015

Perhaps at least some sort of visual hint could be added to indicate that clicking on the castle while the king is selected will result in castling.

@Unihedro
Copy link
Contributor

@Happy0: There already is. The castle-able rook gets hover feedback when the king is selected or held.

@Unihedro
Copy link
Contributor

linked #839

@Unihedro Unihedro added improvement Small incremental improvement to an existing feature controversial labels Sep 12, 2015
@ornicar ornicar closed this as completed Sep 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controversial improvement Small incremental improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants