Add some missing tests for the chess package
#189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncrease_coverage
adamkasztenny
force-pushed
the
increase_coverage
branch
from
fc9d56c
to
f923e71
Compare
ornicar
reviewed
Feb 16, 2020
| "Mode" should { | ||
| "either be Casual or Rated" in { | ||
| Casual.casual must_== true | ||
| Casual.rated must_== false |
There was a problem hiding this comment.
I'm sorry but I don't understand the point of these tests, and other similar tests. How does that not just repeat the equally simple code it's supposed to test:
def casual = this == Mode.Casual
def rated = this == Mode.Rated
I think tests for the sake of testing is not a good thing.
|
I'm sorry that you put all that work in. I can't merge that. Most of these tests are just repeating the code, without possibly catching any bug in it. I don't see any value in them. |
|
No problem, you're the boss. The reason I wrote these is that there are no tests covering these classes. There still is logic in the classes (if statements, filters, etc) so that's why I wrote them. Also, it didn't take me very long so don't worry about it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were missing for some files in the
chesspackage. These were low-hanging fruit, but there are still other files in this package and others that are untested.