Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to node 18 ECF-280 #615

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

christophehurpeau
Copy link
Contributor

Context

Node 16 is no longer supported

Solution

  • Update to node 18
  • Add eslint rule forbid-fetch-import as fetch is available natively in node 18
  • Enable unicorn/prefer-node-protocol

@christophehurpeau christophehurpeau requested a review from a team as a code owner September 25, 2023 16:06
@reviewflow
Copy link

reviewflow bot commented Sep 25, 2023

Progress

☑️ Step 1: ✏️ Write code
☑️ Step 2: 💚 Checks
☑️ Step 3: 👌 Code Review
☑️ Step 4: 🚦 Merge Pull Request

Infos:

✓ JIRA issue: ECF-280

Options:

  • 🔜 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

@christophehurpeau christophehurpeau changed the title feat: update to node 18 ECF-280 feat!: update to node 18 ECF-280 Sep 26, 2023
@christophehurpeau christophehurpeau merged commit 51c7f5e into main Sep 26, 2023
8 of 9 checks passed
@christophehurpeau christophehurpeau deleted the feat/update-to-node-18 branch September 26, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants