Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update node version to 12 [no issue] #354

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

mdcarter
Copy link
Contributor

@mdcarter mdcarter commented Apr 21, 2020

Context

Update required node version to LTS (12.16.2)

Solution

Commits Notes:

Breaking Changes:

Options:

  • This PR is a feature branch
  • Auto merge with [skip ci]
  • Auto merge when this PR is ready and has no failed statuses. (Also has a queue per repo to prevent multiple useless "Update branch" triggers)
  • Automatic branch delete after this PR is merged

@reviewflow reviewflow bot changed the title Chore/update node version to 12 chore: update node version TO-12 Apr 21, 2020
@reviewflow reviewflow bot added the ⚠️ Breaking Changes This issue or pull request will need a new major version - Synced by reviewflow label Apr 21, 2020
@mdcarter mdcarter changed the title chore: update node version TO-12 chore: update node version to 12 [no issue] Apr 21, 2020
@christophehurpeau christophehurpeau changed the title chore: update node version to 12 [no issue] feat: update node version to 12 [no issue] Apr 21, 2020
@@ -3,7 +3,7 @@ version: 2
jobs:
dependencies:
docker:
- image: circleci/node:10.18
- image: circleci/node:12.16.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ne met pas la patch sur circleci: ca permet a circle de prendre la plus recente qu'il a en cache et de ne pas avoir a les mettre a jour avec renovate pour chaque version

@mdcarter mdcarter merged commit 6276917 into master Apr 21, 2020
@reviewflow reviewflow bot deleted the chore/update-node-version-to-12 branch April 21, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Breaking Changes This issue or pull request will need a new major version - Synced by reviewflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants