Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker enhancements #240

Open
1 of 4 tasks
aprokop opened this issue Nov 18, 2016 · 2 comments
Open
1 of 4 tasks

Docker enhancements #240

aprokop opened this issue Nov 18, 2016 · 2 comments

Comments

@aprokop
Copy link

aprokop commented Nov 18, 2016 •
edited by dalg24
Loading

  • Check the error code for create_container in docker-run.py. If it is not successful do not continue executing
  • Add an option to postpone tearing down the container if something goes wrong so one could login into it and investigate
  • Add an option to commit the container at the end of successful execution of docker-run
  • Allow usage of local docker images
@dalg24
Copy link
Collaborator

dalg24 commented Nov 18, 2016

The documentation for the Docker API client in Python is available here. create_container returns a dictionary with a 'Warnings' key. We may want to check that container.get('Warnings') is None.

@aprokop
Copy link
Author

aprokop commented Nov 21, 2016

Updated checklist for using local docker images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dalg24 @aprokop