Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xgc-restart HDF5 tests fail to read #32

Open
chuckatkins opened this issue Sep 16, 2020 · 2 comments
Open

xgc-restart HDF5 tests fail to read #32

chuckatkins opened this issue Sep 16, 2020 · 2 comments
Assignees

Comments

@chuckatkins
Copy link

The adios2-iotest based tests are unable to execute the HDF5 reader because of an improper filename being used. While the test configuration explicitly uses xgc.restart.00040.bp, the HDF5 writer automatically replaces .bp with .h5but the reader does no such substitution so it tries to open the .bp file which doesn't exist.

@chuckatkins
Copy link
Author

I would support removing the auto extension change in the writer since there's plenty of files that use the HDF5 format that don't use it (exodus, cgns, etc.). ADIOS being a lower level library should allow a user to use whatever filename they want. I'll open a corresponding https://github.com/ornladios/adios2 issue with this.

@guj
Copy link
Collaborator

guj commented Sep 16, 2020

Yes, it was an old request to be "smart" about file extensions. The IO class also tries to infer which type of Engine to use by looking at filename extension. That needs to be changed as well then. @pnorbert what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants