Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable WriteRead*MissingPerformGets` tests #3725

Open
vicentebolea opened this issue Jul 28, 2023 · 3 comments
Open

Enable WriteRead*MissingPerformGets` tests #3725

vicentebolea opened this issue Jul 28, 2023 · 3 comments
Assignees

Comments

@vicentebolea
Copy link
Collaborator

In #3722 we disabled WriteRead*MissingPerformGets` tests since they were disabled before this big refactoring but after running clang-format they got re-enabled as the gtest TEST_F does not work if its expanded in a multi-line invocation as it was before this PR. This needs to be resolved.

Enabling these tests results errors when BP5 is used.

Originally posted by @vicentebolea in #3722 (comment)

@vicentebolea
Copy link
Collaborator Author

They were disabled at least since 2018 and edited in this commit: e2f7f7e

@vicentebolea
Copy link
Collaborator Author

@eisenhauer

@eisenhauer eisenhauer self-assigned this Jul 28, 2023
@eisenhauer
Copy link
Member

Yeah, these tests need to be refactored before they'll work with BP5 as they rely upon BP4 behaviour that we explicitly deprecated. Commenting out for now is fine and I'll clean up after this is merged. (There are probably more tests that got disabled at some point and should be re-enabled, so a broader look might be useful.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants