Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for zero-sized reads #3792

Closed
vicentebolea opened this issue Sep 5, 2023 · 5 comments · Fixed by #3878
Closed

Add unit tests for zero-sized reads #3792

vicentebolea opened this issue Sep 5, 2023 · 5 comments · Fixed by #3878
Assignees

Comments

@vicentebolea
Copy link
Collaborator

We want to have a test that performs a zero-sized read of a block in variable with and without compression. We can do this based on some of our simplest read/write tests.

Taken from:

          @pnorbert @vicentebolea @anagainaru generally, shall we add a general test to ADIOS2 for zero-write blocks with and w/o compression? This is a pretty common corner case for us and can easily break :)

Originally posted by @ax3l in #3459 (comment)

@vicentebolea
Copy link
Collaborator Author

Related: #3460

@ax3l
Copy link
Contributor

ax3l commented Oct 26, 2023

Related: #3542

ping @pnorbert @anagainaru #3460 (comment)

@anagainaru
Copy link
Contributor

Sorry @ax3l I somehow did not see this until now.
Just so that it's clear what exactly this corner case is, the test should write data where some blocks are empty (using and not using compression)?

@vicentebolea
Copy link
Collaborator Author

@spyridon97 was originally assigned to this task as it was a good introduction for him how to write a "Simple" test. However, he is now busy with other tasks. I do not have cycles this week for adios2. @anagainaru feel free to re-assign you if you want to take it.

@anagainaru anagainaru self-assigned this Oct 27, 2023
@anagainaru
Copy link
Contributor

I'll finish this tomorrow, for some reason the test I made does not fail before the fix :) so I need to double check what I'm doing wrong. If I can't finish I'll re-assign this back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants