Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatrixGridOrderProvider calculating total price of a configurable product uses all always all variants of the product #121

Open
dimonixx opened this issue Oct 13, 2020 · 0 comments

Comments

@dimonixx
Copy link

Summary
In the MatrixGridOrderProvider method getTotalPriceFormatted all variants of configurable product are used to calculate the total price, even if the variant is not present on the list: https://github.com/oroinc/orocommerce/blob/master/src/Oro/Bundle/ShoppingListBundle/Layout/DataProvider/MatrixGridOrderProvider.php#L97-L110

Is there a reason for this behavior ?
In this case loading the ShoppingList View Page prices for all the variants of a configurable product are fetch , what causes a an overhead by products which have a lot of variants.

Actual Result
All variants of the configurable product are taken in account when calculating the total.

Expected Result
Only variants present on the ShoppingList should be taken in account , when calculating the total price of the configurable product.

Details about your environment

  • OroCommerce version: 3.2., 4.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant