Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite CpalBackend::build_input to make it similar to build_output #51

Closed
Jerboas86 opened this issue Nov 15, 2021 · 3 comments
Closed
Labels
good first issue Good for newcomers

Comments

@Jerboas86
Copy link
Contributor

Connection to the audio hardware is made through io::build_output and io::build_input functions.

  • build_output instantiates the output stream.
  • build_input instantiates the input stream.

A rewrite of io::build_output has been made by PR #36. This PR makes it possible for the end user to change output stream parameters like:

  • number of output channels
  • latency settings
  • sample rate
    But this PR stopped there, and the work has not been done for build_input function

A rewrite of io::build_input should be made to make stream configuration coherent between build_output and build_input functions. It would also be helpful if both functions used similar type system to define them.

@Jerboas86 Jerboas86 added the good first issue Good for newcomers label Nov 15, 2021
@orottier orottier added this to the Version 1.0 release milestone Dec 29, 2021
@orottier
Copy link
Owner

orottier commented Apr 4, 2022

Removing the v1 milestone because this is not part of the public API.
The Microphone struct however is, and could benefit from the same config settings we'd like to pass to the io mod. Let's fix that after the v1 release (and introduce a Microphone::with_config constructor)

@orottier orottier removed this from the Version 1.0 milestone Apr 4, 2022
@orottier
Copy link
Owner

Some work was done but we still need to implement the desired buffer_size AKA latency hint

@orottier orottier changed the title Rewrite io::build_input to make it similar to io::build_output Rewrite CpalBackend::build_input to make it similar to build_output Jul 26, 2022
@orottier
Copy link
Owner

orottier commented May 7, 2023

Fixed in #264

@orottier orottier closed this as completed May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants