Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp-ssl-connect doesn't verify server certificates #189

Open
se-mz opened this issue Jun 29, 2022 · 0 comments
Open

tcp-ssl-connect doesn't verify server certificates #189

se-mz opened this issue Jun 29, 2022 · 0 comments

Comments

@se-mz
Copy link

se-mz commented Jun 29, 2022

cl-async will happily connect to e.g. wrong.host.badssl.com unless you create the SSL context yourself. The offending code seems to do this explicitly:

         (ctx (or ssl-ctx
                  (let ((ctx (create-ssl-ctx :options ssl-options)))
                    (ssl-ctx-set-default-verify-paths ctx)
                    ;; TODO better verify support
                    (ssl-ctx-set-verify ctx +ssl-verify-none+ (cffi:null-pointer))
                    ctx))))

What is the reason for not using (ssl-ctx-set-verify ctx +ssl-verify-peer+ (cffi:null-pointer)) here? Even if there is no support for user callbacks yet, surely that would be a saner default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant