Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tcp-send to tcp-connect #35

Closed
orthecreedence opened this issue Dec 2, 2012 · 1 comment
Closed

Rename tcp-send to tcp-connect #35

orthecreedence opened this issue Dec 2, 2012 · 1 comment

Comments

@orthecreedence
Copy link
Owner

...and make data an optional keyword, also add a tcp-send wrapper that just calls tcp-connect for backwards compatibility.

Also, add a connect-cb to tcp-connect.

This is a breaking API change (once tcp-send is fully deprecated), but makes much more sense. Sockets are connected, then data is sent (generally), not transparently used to blast data out.
@orthecreedence
Copy link
Owner Author

There. Now I feel a while lot better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orthecreedence