Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libuv default location on Windows patch #12

Open
autcrock opened this issue Aug 4, 2017 · 0 comments
Open

Libuv default location on Windows patch #12

autcrock opened this issue Aug 4, 2017 · 0 comments

Comments

@autcrock
Copy link

autcrock commented Aug 4, 2017

Hi there and thanks for the excellent work you are doing.

Libuv installs on Windows into C:\Program Files\libuv, which breaks a number of builds in quicklisp with dependencies on libuv, so I've patched as follows for your consideration:

@@ -1,6 +1,7 @@
(in-package :libuv)

-(cc-flags #+windows "-Ic:/include/"
+(cc-flags #+windows "-IC:/Program Files/libuv/include"

  •      #+windows "-Ic:/include/"
         #+windows "-Ic:/include/uv/"
         #+darwin "-I/usr/local/include/")
    

This fix in turn breaks cffi's grovel, so I've also lodged a separate patch to fix that with the developers over there.

The patch above doesn't display properly (has a big dot in the middle etc) so I gave up I'm sorry, but the intent should be clear.

Cheers and thanks for your time

Mike Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant