Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node_redis v0.8.3 or remove explicit version dependency #5

Merged
merged 1 commit into from May 17, 2013
Merged

Use node_redis v0.8.3 or remove explicit version dependency #5

merged 1 commit into from May 17, 2013

Conversation

prashantrajan
Copy link
Contributor

Any chance we could bump up the node_redis dependency to the latest version or remove the explicit version dependency altogether?

Thanks for building this lib!
I've been evaluating this library and it seems to work as expected (basic use case of failover to a slave when master dies).
I really like this lightweight approach as compared to the heavier solutions mentioned in redis/node-redis#302

I'm wondering if you have used this lib in a production environment? Any issues to be aware of?

jamessharp added a commit that referenced this pull request May 17, 2013
@jamessharp jamessharp merged commit 5cc17ea into ortoo:master May 17, 2013
@jamessharp
Copy link
Member

Thanks. I'd like to keep the version explicit for now because this library relies on node_redis's internals working in a particular way.

I've been using this in production for a while now and it's been fine. Saying that I don't think it's actually had to failover yet... The main issues are as mentioned in the issue - there will be some downtime on failover and requests sent during this period will be lost (as will any pub/subs)

@prashantrajan
Copy link
Contributor Author

Thanks for merging.
I've started using this lib in a production env - works as expected. Good stuff!

@prashantrajan
Copy link
Contributor Author

Is pub/sub not supported at all or it breaks when the failover occurs? That wasn't clear from the issue.

@jamessharp
Copy link
Member

It will break when the failover occurs. Otherwise it should be fine.

On 17 May 2013, at 10:58, Prashant Nadarajan notifications@github.com wrote:

Is pub/sub not supported at all or it breaks when the failover occurs? That wasn't clear from the issue.


Reply to this email directly or view it on GitHub.

@prashantrajan prashantrajan deleted the node_redis_v0.8.3 branch May 17, 2013 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants