Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea Autosize Prop #107

Closed
bradley-varol opened this issue Mar 19, 2021 · 7 comments · Fixed by #201
Closed

Textarea Autosize Prop #107

bradley-varol opened this issue Mar 19, 2021 · 7 comments · Fixed by #201
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bradley-varol
Copy link

bradley-varol commented Mar 19, 2021

Description

It might be a good idea to implement automatic resizing for textareas!
Having tried several packages for this, i highly recommend the following:
https://github.com/devstark-com/vue-textarea-autosize

I am happy to implement this as a feature :)

Why Oruga need this feature

It's a common request and is not difficult to implement. Having this as part of Orgua will save users the need to search for a working implementation.

@astagi astagi self-assigned this Mar 23, 2021
@astagi astagi added the enhancement New feature or request label Mar 23, 2021
@astagi
Copy link
Member

astagi commented Mar 23, 2021

Sounds great @bradley-varol , thank you! I'll insert it in the backlog

@astagi
Copy link
Member

astagi commented Mar 24, 2021

Sorry @bradley-varol I missed this part

I am happy to implement this as a feature :)

so you want to implement this and send a PR? That would be awesome, I can assign it to you!

@bradley-varol
Copy link
Author

bradley-varol commented Mar 24, 2021

Sorry @bradley-varol I missed this part

I am happy to implement this as a feature :)

so you want to implement this and send a PR? That would be awesome, I can assign it to you!

Absolutely! I'll get it done this weekend 👌🏻

@astagi
Copy link
Member

astagi commented Mar 24, 2021

Sounds great @bradley-varol!! If you have any question let us know! (we're also active on Discord ✌🏻)

@astagi astagi assigned bradley-varol and unassigned astagi Mar 24, 2021
@bradley-varol
Copy link
Author

bradley-varol commented Mar 29, 2021

Sorry, I didn't get a chance to do this over the weekend!

I did take a look at the codebase - do you mind sharing briefly in which files you'd do the height maths and onInput handling for this? Usually I'd stick this in a textarea component but in this case i'd be extending the Input component. Would you suggest creating a new Mixin in utils?

@jtommy
Copy link
Member

jtommy commented Mar 29, 2021

@bradley-varol you might add all to FormElementMixin 😉

@jtommy jtommy added the good first issue Good for newcomers label Apr 14, 2021
@astagi
Copy link
Member

astagi commented May 16, 2021

Hey @bradley-varol any updates on this? Let us know if you need help with this feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants