Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of padding on pagination buttons #27

Closed
mateuswetah opened this issue Aug 31, 2020 · 0 comments
Closed

Lack of padding on pagination buttons #27

mateuswetah opened this issue Aug 31, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mateuswetah
Copy link
Contributor

mateuswetah commented Aug 31, 2020

Overview of the problem

Oruga version: [0.1.4]
Vuejs version: [2.6.11]
OS/Browser: Ubuntu 20.04/Firefox

Description

The pagination buttons have a min-width but no padding. This makes links that have big numbers or even the previous and next buttons get a bit weird with the text next to the border:
image

I was thinking on adding a --oruga-pagination-link-padding variable and set it to the same value of --oruga-button-padding at first. This would leave things this way:
image

Notice that the buttons are not always squared anymore once you get to two digits, but I guess this is fine, its what I would expect.

@jtommy jtommy added the good first issue Good for newcomers label Oct 25, 2020
@jtommy jtommy closed this as completed in 01585fd Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants