Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated methods for vue 3 #39

Closed
bzd2000 opened this issue Oct 9, 2020 · 6 comments
Closed

Deprecated methods for vue 3 #39

bzd2000 opened this issue Oct 9, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@bzd2000
Copy link
Contributor

bzd2000 commented Oct 9, 2020

Hi,

Thx for providing the Vue 3 branch.

There are some methods now depricated:
Vue warn]: beforeDestroy has been renamed to beforeUnmount.
at
at <OTable data= (3) [{…}, {…}, {…}] isPaginated:="" true,="" ... >
at <HostListings onVnodeUnmounted=fn ref=Ref< Proxy {…} > >
at
at <HostLayout onVnodeUnmounted=fn ref=Ref< Proxy {…} > >
at
at

I can fix it, but it seems there is one code base for vue2 and vue3.
What is strategy to maintain those 2?

@jtommy
Copy link
Member

jtommy commented Oct 9, 2020

Yes, i know and I added it the mixin.
What's the warning?

@bzd2000
Copy link
Contributor Author

bzd2000 commented Oct 9, 2020

Vue warn]: beforeDestroy has been renamed to beforeUnmount.

@jtommy
Copy link
Member

jtommy commented Oct 9, 2020

Mmm ok, I should remove it when Vue version is 3

@jtommy jtommy self-assigned this Oct 9, 2020
@jtommy jtommy added the enhancement New feature or request label Oct 9, 2020
@bzd2000
Copy link
Contributor Author

bzd2000 commented Oct 9, 2020

@jtommy , i have some other issues.
I'll log them all?

@jtommy
Copy link
Member

jtommy commented Oct 9, 2020

You should open new issues, thanks

@jtommy
Copy link
Member

jtommy commented Nov 8, 2020

I'm working on rewriting a different codebase for Vue 3

@jtommy jtommy closed this as completed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants