Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Datepicker Crashes Browser #624

Closed
dylanson25 opened this issue Oct 13, 2023 · 2 comments · Fixed by #625
Closed

Bug: Datepicker Crashes Browser #624

dylanson25 opened this issue Oct 13, 2023 · 2 comments · Fixed by #625
Assignees
Labels
bug Something isn't working

Comments

@dylanson25
Copy link

Overview of the problem

"@oruga-ui/oruga-next": "^0.6.0",
"@oruga-ui/theme-bulma": "^0.2.11",
"vue": "^3.3.4",

Description

There is a bug in my Datepicker component and the documentation page. When navigating within the datepicker component using the arrow up/down keys on the days of the week, it causes the browser to crash.

Steps to reproduce

Grabacion.de.pantalla.2023-10-13.a.la.s.12.07.02.mov

The same problem can be replicated in the official documentation.

Grabacion.de.pantalla.2023-10-13.a.la.s.12.37.38.mov

Actual behavior

Oficial page

Captura de Pantalla 2023-10-13 a la(s) 12 29 02

My local

Captura de Pantalla 2023-10-13 a la(s) 12 08 33
@jtommy jtommy added the bug Something isn't working label Oct 13, 2023
@jtommy
Copy link
Member

jtommy commented Oct 13, 2023

@mlmoravek you are working on refactoring, can you take a look?

@mlmoravek
Copy link
Member

@dylanson25 Thanks for reporting this bug.
The bug comes from an endless while loop, even after the refactoring.

https://github.com/oruga-ui/oruga/blob/860d08386c5932d01d5738cddebfb44a10194cf7/packages/oruga-next/src/components/datepicker/DatepickerTableRow.vue#L160C1-L172C2

I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants