Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement teleport | update composables #652

Merged
merged 12 commits into from
Nov 13, 2023

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Nov 3, 2023

Fixes #603

Proposed Changes

  • Add PositionWrapper component
  • Add PositionWrapper to Dropdown, Tooltip
  • Rename property appendToBody to teleport
  • Add teleport property to Modal, Sidebar
    • Sidebar: remove fixedClass, staticClass, absoluteClass, rightClass
    • Sidebar: add inlineClass, positionClass
  • Update Autocomplete component to use Dropdown component internally
  • Update TagInput
  • Add clickoutisde composable
  • Update Eventlistener composable
  • Update docs

@mlmoravek mlmoravek requested a review from jtommy November 3, 2023 10:21
@mlmoravek mlmoravek self-assigned this Nov 3, 2023
Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 249f335
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/654cfa92c5e709000784d9dd
😎 Deploy Preview https://deploy-preview-652--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 115 lines in your changes are missing coverage. Please review.

Comparison is base (3df516b) 58.61% compared to head (249f335) 59.02%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #652      +/-   ##
===========================================
+ Coverage    58.61%   59.02%   +0.40%     
===========================================
  Files           89       97       +8     
  Lines         2448     2716     +268     
  Branches       819      913      +94     
===========================================
+ Hits          1435     1603     +168     
- Misses         902     1002     +100     
  Partials       111      111              
Flag Coverage Δ
oruga 67.21% <ø> (ø)
oruga-next 50.98% <60.20%> (+2.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ruga-next/src/components/dropdown/DropdownItem.vue 50.00% <ø> (ø)
...ages/oruga-next/src/composables/useInputHandler.ts 37.34% <100.00%> (-1.48%) ⬇️
packages/oruga-next/src/utils/helpers.ts 13.70% <ø> (+2.08%) ⬆️
packages/oruga-next/src/utils/unrefElement.ts 100.00% <100.00%> (ø)
...s/oruga-next/src/composables/useScrollingParent.ts 86.66% <86.66%> (ø)
...ges/oruga-next/src/composables/useEventListener.ts 81.25% <81.25%> (-2.09%) ⬇️
...ages/oruga-next/src/composables/useClickOutside.ts 27.27% <27.27%> (ø)
...-next/src/components/autocomplete/Autocomplete.vue 60.83% <61.66%> (+6.20%) ⬆️
packages/oruga-next/src/utils/PositionWrapper.vue 70.37% <70.37%> (ø)
...es/oruga-next/src/components/dropdown/Dropdown.vue 42.96% <39.06%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek marked this pull request as ready for review November 9, 2023 08:17
@mlmoravek mlmoravek merged commit d0c9824 into oruga-ui:develop Nov 13, 2023
10 of 11 checks passed
@mlmoravek mlmoravek deleted the teleport branch November 13, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: replace appendToBody by Teleport
1 participant