Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): prevent TableColumn function props trigger recursive reactivity #848

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

mlmoravek
Copy link
Member

Fixes #838

Proposed Changes

  • call toRow for props to prevent produce "Maximum recursive updates exceeded" when functions are given

@mlmoravek mlmoravek added the bug Something isn't working label Mar 9, 2024
Copy link

netlify bot commented Mar 9, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit c2cc3af
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65ec91c2232b990008394bfd
😎 Deploy Preview https://deploy-preview-848--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 8.61%. Comparing base (484cfe8) to head (c2cc3af).
Report is 18 commits behind head on develop.

Files Patch % Lines
packages/oruga/src/components/table/Table.vue 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #848       +/-   ##
===========================================
- Coverage    56.71%   8.61%   -48.11%     
===========================================
  Files           30     109       +79     
  Lines         1511    5294     +3783     
  Branches       544    1953     +1409     
===========================================
- Hits           857     456      -401     
- Misses         654    3846     +3192     
- Partials         0     992      +992     
Flag Coverage Δ
oruga-next 8.61% <0.00%> (-48.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek changed the title fix(table): prevent TableColumn function props trigger reactivity fix(table): prevent TableColumn function props trigger recursive reactivity Mar 9, 2024
@mlmoravek mlmoravek merged commit 8f83b71 into oruga-ui:develop Mar 9, 2024
6 of 9 checks passed
@mlmoravek mlmoravek deleted the fix/table/tdattrs branch March 9, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Column tdAttrs produce "Maximum recursive updates exceeded"
1 participant