Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taginput): selection with autocomplete on non string items #889

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

dauriata
Copy link
Contributor

Fixes #886

Proposed Changes

Changes to addItem function to fix selection with autocomplete and non string items.

Changes to createItem and beforeAdding to be used with any input type, I though it could be left open to the developer to use a transform or validation function for any type while using autocomplete.

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 3e2237a
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/662682793b295300085673bd
😎 Deploy Preview https://deploy-preview-889--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek added the bug Something isn't working label Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 22.08%. Comparing base (484cfe8) to head (3e2237a).
Report is 50 commits behind head on develop.

Files Patch % Lines
...ackages/oruga/src/components/taginput/Taginput.vue 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #889       +/-   ##
============================================
- Coverage    56.71%   22.08%   -34.64%     
============================================
  Files           30      110       +80     
  Lines         1511     5285     +3774     
  Branches       544     1946     +1402     
============================================
+ Hits           857     1167      +310     
- Misses         654     3279     +2625     
- Partials         0      839      +839     
Flag Coverage Δ
oruga-next 22.08% <0.00%> (-34.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit 930c397 into oruga-ui:develop Apr 22, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taginput with autocomplete does not work if data is an array of objects
2 participants