Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to use with own redux store #617

Merged
merged 3 commits into from Nov 15, 2018

Conversation

davidfurlong
Copy link
Contributor

@davidfurlong davidfurlong commented Nov 1, 2018

See #616 for original conversation

Todos

  • Docs

Comments

I had some troubles with the tests, as it seems they use the npm packages rather than the local builds and there were a lot of unrelated console errors. The Contributing.md docs seem to not be updated for this npm package (Run the full project test suite with the go test ./... (or equivalent) command and confirm that it passes.)

Also it seems some files weren't properly prettified, so they are updated although I didn't change them.

I also updated some flow types

Usage

// ...
import { oryReducer } from 'ory-editor-core'

const reducer = combineReducers({
  // ...
  ory: oryReducer 
});

const store = createStore(reducer, null, middleware);

new Editor({ store })

Signed-off-by: David Furlong <dvfurlong@googlemail.com>
@davidfurlong davidfurlong changed the title Adds ability to use with own redux store [WIP] Adds ability to use with own redux store Nov 1, 2018
Signed-off-by: David Furlong <dvfurlong@googlemail.com>
@coveralls
Copy link

coveralls commented Nov 1, 2018

Coverage Status

Coverage increased (+0.03%) to 49.058% when pulling 2dc4714 on davidfurlong:ory-scoped-store into 7efd053 on ory:master.

@davidfurlong davidfurlong changed the title [WIP] Adds ability to use with own redux store Adds ability to use with own redux store Nov 1, 2018
@aeneasr
Copy link
Collaborator

aeneasr commented Nov 2, 2018

Thank you! Currently out of office, will review on Monday :)

@davidfurlong
Copy link
Contributor Author

Bump :)

@aeneasr
Copy link
Collaborator

aeneasr commented Nov 13, 2018

Whoops! Thanks :) Reviewing now!

@aeneasr
Copy link
Collaborator

aeneasr commented Nov 13, 2018

LGTM! Maybe add a bit of docs to the example and then it's good to go imo :)

@davidfurlong
Copy link
Contributor Author

LGTM! Maybe add a bit of docs to the example and then it's good to go imo :)

I'm struggling to find the right place in the docs for this. Perhaps. editor/docs/tutorials.md ?

@aeneasr
Copy link
Collaborator

aeneasr commented Nov 13, 2018

I think adding a few commented lines in /examples would be enough for now!

@davidfurlong
Copy link
Contributor Author

davidfurlong commented Nov 13, 2018

Ok @aeneasr think I got it. Not sure how documentation.js picks up ES exports though. /examples is just one example so I didn't understand how it would work without creating another example

@aeneasr
Copy link
Collaborator

aeneasr commented Nov 15, 2018

Thank you, david!

@aeneasr aeneasr merged commit 62868ba into react-page:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants