New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to use with own redux store #617
Conversation
Signed-off-by: David Furlong <dvfurlong@googlemail.com>
8b768e9
to
7a02cdd
Compare
Signed-off-by: David Furlong <dvfurlong@googlemail.com>
3fafee0
to
c9b594e
Compare
Thank you! Currently out of office, will review on Monday :) |
Bump :) |
Whoops! Thanks :) Reviewing now! |
LGTM! Maybe add a bit of docs to the example and then it's good to go imo :) |
I'm struggling to find the right place in the docs for this. Perhaps. editor/docs/tutorials.md ? |
I think adding a few commented lines in |
Ok @aeneasr think I got it. Not sure how documentation.js picks up ES exports though. |
Thank you, david! |
See #616 for original conversation
Todos
Comments
I had some troubles with the tests, as it seems they use the npm packages rather than the local builds and there were a lot of unrelated console errors. The
Contributing.md
docs seem to not be updated for this npm package (Run the full project test suite with the go test ./... (or equivalent) command and confirm that it passes.
)Also it seems some files weren't properly
prettified
, so they are updated although I didn't change them.I also updated some flow types
Usage