Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RG-199] Add test for wave_* tcl commands #847

Closed
wants to merge 11 commits into from

Conversation

skyler-rs
Copy link
Contributor

@skyler-rs skyler-rs commented Dec 1, 2022

Note: This is currently failing due to libgtk-3.so.0 being missing on one of the CI targets, checking with Nadeem on how to resolve.

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue: [RG-199]
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

  • Testing was done manually due to CI issues

What does this pull request change?

  • Now that GTKWave stdout and stderr are reported in the console, we can use foedag.log for normal tcl verification
    • A test has been added to test the various wave_* commands

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Testing

  • Note: Delays are added after file load and refresh operations because the test.vcd is from a real design that takes a moment to load which could cause the testcase to fail. This is only a failure situation because the test is running so fast that after we request that GTKWave opens a file (asynchronously), we are already grepping the log for the load result before GTKWave has finished loading.

@alaindargelas
Copy link
Contributor

alaindargelas commented Dec 1, 2022

@skyler-rs please add a test for wave_open with an actual simulation file:
wave_open <filename>
From what I tried, that does not work.

@skyler-rs
Copy link
Contributor Author

@skyler-rs please add a test for wave_open with an actual simulation file:
wave_open
From what I tried, that does not work.

Hey @alaindargelas, there is a line that tests that https://github.com/os-fpga/FOEDAG/pull/847/files#diff-ecc05c174feb34b32733c85157a214ef61195444c26ec6d0fbfa84c98a645074R84

test.vcd is a copy of a tb.vcd from the Raptor test dirs.

Note there was an issue w/ wave_open when using relative paths (absolute should work fine if you need to use it now) which will be fixed with #846.

@github-actions github-actions bot added the github label Dec 2, 2022
@skyler-rs skyler-rs marked this pull request as draft December 5, 2022 21:20
@skyler-rs
Copy link
Contributor Author

This will need some more time to test after the install/uninstall changes are stable. This probably will have some delay issues with our CI that will need debugging. Closing for now to avoid confusion.

@skyler-rs skyler-rs closed this Dec 12, 2022
@ravic-rs ravic-rs deleted the task/RG-199/add_gtkwave_interface_test branch June 7, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants