Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make protoc version 3.0 available through the plugin #4

Closed
seh opened this issue Jun 30, 2015 · 6 comments
Closed

Make protoc version 3.0 available through the plugin #4

seh opened this issue Jun 30, 2015 · 6 comments

Comments

@seh
Copy link

seh commented Jun 30, 2015

As previously mentioned in #1, please consider publishing a version of the Maven plugin that will use your protoc-jar version 3.0.0(-a3), so that we'll have the "proto3" syntax available.

It looks like it may be as "simple" as creating a new branch and changing a few dependency versions in the POM, as well as updating the documentation to mention the new version. But then there's also the matter of releasing the artifact.

Thanks for providing this plugin. It's proven to be easy to use.

@seh
Copy link
Author

seh commented Jun 30, 2015

Related issue: os72/protoc-jar#2.

@os72
Copy link
Owner

os72 commented Jul 2, 2015

Will have a look. Expect a new config parameter to control the protoc version since the new jar will contain all flavors now

@seh
Copy link
Author

seh commented Jul 2, 2015

Fantastic. If there's anything you'd like me to try to help this along, please let me know. I was intending to figure out how you maintain your separate branches, and how they relate to what's on the master branch.

@os72
Copy link
Owner

os72 commented Jul 8, 2015

Pushed 3.0.0-a3-SNAPSHOT, could you give it a try (clone, build, try)? It will run latest bundled protoc, unless you specify <protocVersion> under <configuration>

@seh
Copy link
Author

seh commented Jul 10, 2015

I'm able to build and use the version 3 plugin without any problems. I didn't exercise trying to change the version used by the protoc compiler; using the latest version is my intention.

One suggestion for documentation: The generated code requires that the POM declare a compile-time dependency on the com.google.protobuf:protobuf-java artifact.

@os72
Copy link
Owner

os72 commented Jul 15, 2015

Released 3.0.0-a3

@os72 os72 closed this as completed Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants