Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drgn could use libkdumpfile for more crash dumps #15

Closed
jwadams opened this issue Sep 25, 2019 · 0 comments
Closed

drgn could use libkdumpfile for more crash dumps #15

jwadams opened this issue Sep 25, 2019 · 0 comments

Comments

@jwadams
Copy link

jwadams commented Sep 25, 2019

drgn has issues with regular kernel core files; things like module data etc aren't readable. By default, drgn only used libkdumpfile for "KDUMP" files. I was able to work around this by:

--- a/libdrgn/program.c
+++ b/libdrgn/program.c
@@ -195,7 +195,7 @@ drgn_program_set_core_dump(struct drgn_program *prog, const char *path)
        err = has_kdump_signature(path, prog->core_fd, &is_kdump);
        if (err)
                goto out_fd;
-       if (is_kdump) {
+       if (is_kdump || 1) {
                err = drgn_program_set_kdump(prog);
                if (err)
                        goto out_fd;

which just forces the use of kdumpfile, but that prevents user-space core file handling and is a bit of a hack. Some way to use kdumpfile for kernel cores would be nice, since it handles all of the complicated address space stuff.

@osandov osandov closed this as completed in b05cc0e Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant