Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator should not check branch probabilities when a probability property is undefined #2821

Open
joeseibel opened this issue Jul 1, 2022 · 0 comments

Comments

@joeseibel
Copy link
Contributor

The validator checks that branch probabilities sum to 1 even if a branch specifies a probability with and undefined property. This is a problem because the property could be supplied later via containment or extension. The validator places an error on the following model, but it shouldn't:

package too_much_validation
public
  system s
  end s;

  system implementation s.i1
    annex EMV2 {**
      use behavior too_much_validation::machine1;

      component error behavior
        events
          error1: error event;
        transitions
          transition1: state1 -[error1]-> (state2 with 0.125, state3 with my_set::my_real);
      end component;
    **};
  end s.i1;

  system implementation s.i2 extends s.i1
    annex EMV2 {**
      properties
        my_set::my_real => 0.875 applies to transition1;
    **};
  end s.i2;

  annex EMV2 {**
    error behavior machine1
      states
        state1: initial state;
        state2: state;
        state3: state;
    end behavior;
  **};
end too_much_validation;

property set my_set is
  my_real: aadlreal applies to (all);
end my_set;

In this case, the property is supplied in the classifier extension s.i2, so the probabilities do sum up to 1 in the context of s.i2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant