Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting PR #347 on architecture tests as it does not resolve manifests correctly at the moment #396

Closed
cdrage opened this issue Apr 26, 2024 · 3 comments

Comments

@cdrage
Copy link

cdrage commented Apr 26, 2024

For now could we should revert #347 as it's incorrectly checking the image / not supporting a multi-architecture manifest.

I have a feeling it's because the test added was only to check to see if there was a failure.

However, we are not testing for example checking a manifest with two images (arm64 and amd64) and making sure we can build cross-arch (example, building the amd64 image on a arm64 bib container).

See the results here: #347 (comment) manually reverting the commit, I am able to now build from a manifest.

@deboer-tim @mvo5 @kingsleyzissou

@mvo5
Copy link
Collaborator

mvo5 commented Apr 26, 2024

I'm fine with reverting #347 to unblock you, let's have a quick check if #397 helps (it seems it does)

@achilleas-k
Copy link
Member

Is this issue resolved?

@kingsleyzissou
Copy link
Contributor

It is, #397 fixed it. So I'll close the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants