Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to avoid - in the name of directives #71

Closed
jkonecny12 opened this issue May 10, 2024 · 1 comment · Fixed by #83
Closed

Try to avoid - in the name of directives #71

jkonecny12 opened this issue May 10, 2024 · 1 comment · Fixed by #83

Comments

@jkonecny12
Copy link

I noticed that there are multiple commands using - to support two versions of the same thing. I think it would give more sense to change this based on the argument passed in.

Example:
filesystem.boot-efi => filesystem.boot.efi = True
filesystem.boot => would default to filesystem.boot.efi = False

external.osbuild.depsolve-dnf4 => external.osbuild.depsolve.dnf4 = True
external.osbuild.depsolve-dnf4 => external.osbuild.depsolve.dnf4 = False

On the same note, please switch using from - to _. Please are more used to this with Ansible, so it wouldn't be confusing. In general I think this project should try to get closest as possible to Ansible.

@supakeen
Copy link
Member

As far as the - goes in the depsolves. I'm kind of projecting a hierarchical structure on the dot notations; which I maybe shouldn't do.

I'm open to default to _ instead of - in directive names.

@supakeen supakeen changed the title Try to avoid - in the name of the "actions" Try to avoid - in the name of directives May 10, 2024
@supakeen supakeen self-assigned this May 15, 2024
@supakeen supakeen linked a pull request May 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants