Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create pull request template #21

Closed
HassanBahati opened this issue Jan 17, 2023 · 7 comments · Fixed by #63
Closed

create pull request template #21

HassanBahati opened this issue Jan 17, 2023 · 7 comments · Fixed by #63
Labels
good first issue Good for newcomers

Comments

@HassanBahati
Copy link
Collaborator

Reference

@HassanBahati HassanBahati added the good first issue Good for newcomers label Jan 17, 2023
@c00kie123
Copy link

Hi, I am interested! Let me know any requirements you have

@HassanBahati
Copy link
Collaborator Author

hi @c00kie123 , you may base on this but also feel free to add anything else you find necessary

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.

  • I have run pnpm run test to check if all tests are passing, and/or pnpm run test -- -u to update snapshots if I created and/or updated React Components.

  • I have checked that the build works locally and that npm run build work fine.

  • I've covered new added functionality with unit tests if necessary.

  • I've included issue number in the "Closes #ISSUE-NUMBER" part of the "What are the relevant tickets?" section to link the issue.

How should this be manually tested? Please include the steps to be done inorder to setup and test this PR.

What are the relevant tickets? Closes #

Screenshots (optional)

@HassanBahati
Copy link
Collaborator Author

Hi @c00kie123 any progress on this?

@mosespace
Copy link
Member

mosespace commented Feb 21, 2023

@HassanBahati Hi, should the request template visible in the repository's docs directory or in a hidden director?

Let me know if this was done! Ummmm!
If not, I can jump straight away to contributing on it!

@HassanBahati
Copy link
Collaborator Author

@HassanBahati Hi, should the request template visible in the repository's docs directory or in a hidden director?

hi @mosespace , it pull request template should be at in the .github directory

@mosespace
Copy link
Member

@HassanBahati I think that's what I made!

@HassanBahati Hi, should the request template visible in the repository's docs directory or in a hidden director?

hi @mosespace , it pull request template should be at in the .github directory

Hi @HassanBahati i think it's were i located it

@HassanBahati
Copy link
Collaborator Author

Hi @HassanBahati i think it's were i located it

Yes it is located right

HassanBahati added a commit that referenced this issue Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants