Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sonar #1481

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: sonar #1481

merged 1 commit into from
Dec 11, 2023

Conversation

degenaro
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@degenaro
fix: sonar
8897411 
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
degenaro
degenaro commented Dec 11, 2023
View reviewed changes
Copy link
Collaborator Author

@degenaro degenaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AleJo2995
AleJo2995 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@degenaro degenaro merged commit 4e7e8fd into develop Dec 11, 2023
16 checks passed
@degenaro degenaro deleted the fix/sonar-xccdf branch December 11, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleJo2995 AleJo2995 AleJo2995 approved these changes

@mrgadgil mrgadgil Awaiting requested review from mrgadgil

@vikas-agarwal76 vikas-agarwal76 Awaiting requested review from vikas-agarwal76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@degenaro @AleJo2995