fix: add check for empty label to fix failure for statement with no label property #1507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
develop
->main
)Quality assurance (all should be covered).
Summary
Updates Catalog Interface
get_statement_part_id_map
to check if the label is empty. If the label is empty andlabel_as_key
is True, the statement is not added to the map.This may be only a partial fix because any statement that does not have a label property would be skipped over here.
Test added to verify the fix
Alternatives
Some alternatives fixes I tried.
Fixes #1502
Key links:
Before you merge