Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: community call #1516

Merged
merged 13 commits into from
Feb 16, 2024
Merged

fix: community call #1516

merged 13 commits into from
Feb 16, 2024

Conversation

degenaro
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

AleJo2995 and others added 4 commits May 4, 2023 09:47
@AleJo2995
fix: update community call information
f9d5296 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: removing unneded separators
22ef43b 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@degenaro
fix: community meetings
e35ccef 
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
@degenaro
fix: agenda and notes
5253cdf 
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
@degenaro degenaro changed the title Fix/community call fix: community meetings Feb 13, 2024
@degenaro degenaro changed the title fix: community meetings fix: community-call Feb 13, 2024
@degenaro degenaro changed the title fix: community-call fix: community call information Feb 13, 2024
@degenaro degenaro changed the title fix: community call information fix: upgrade python Feb 13, 2024
@degenaro degenaro changed the title fix: upgrade python fix: community call Feb 14, 2024
@degenaro
Copy link
Collaborator Author

Reviewers - please suggest improvements, if any - thx!

jpower432
jpower432 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of suggestions, but nothing that would block this change. Just discussion points.

README.md

- Meeting agenda and notes: [here](https://docs.google.com/document/d/1z9xvt-Z97j4CtEH1-nR9sMWul7jQkUi_fNY7BdMPgxM/edit#heading=h.nohkp1kbeduj)

##### Chat anytime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not block this particular change, but since the Slack and Zoom meeting are for the oscal-compass organization, I wonder if this type of information would belong in an organization profile or in a community repository.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would this go, when I visit https://github.com/oscal-compass? Also, replicating information seemed doomed to inconsistency, so perhaps one should point to the other.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have an organizational profile READMEs so the information would be available when the organization link is visited. Example here for the CNCF org - https://github.com/cncf/.github/tree/master/profile. Totally agree that we should not duplicate the information, but link to it.

Copy link
Collaborator Author

@degenaro degenaro Feb 14, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think you mean here https://github.com/oscal-compass/.github in outrcase. Seems fine to me, but then perhaps we should open an issue against that repo and make a proposal as to what it should contain, pre-CNCF.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I can open that issue.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added here oscal-compass/.github#1

README.md Outdated

- Meeting Id: 927 2923 5315

- Meeting agenda and notes: [here](https://docs.google.com/document/d/1z9xvt-Z97j4CtEH1-nR9sMWul7jQkUi_fNY7BdMPgxM/edit#heading=h.nohkp1kbeduj)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should add a process on how to get topics on the agenda

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have an official process yet...but once we do we can certainly add words to the README.md community meetings section, if that make sense.

@degenaro
Copy link
Collaborator Author

Dear Reviewers: please see changes since initial delivery.

  • every other Tue
  • calendar link & instructions
  • login notes
    Comments?

degenaro and others added 4 commits February 14, 2024 12:28
@degenaro
fix: make mdformat happy.
660833c 
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
@degenaro
fix: update calendar info
61225c1 
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
@AleJo2995
fix: add a passcode to zoom meeting
f473a96 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: correct wording for zoom login
7ffc3e7 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
Copy link
Collaborator

@degenaro Ash from CNCF has changed the zoom settings so we are able to use a Passcode instead of doing a login. I have added the Passcode in the latest commit as well as changed the wording for Zoom login, please take a quick look before merging.

AleJo2995
AleJo2995 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleJo2995
fix: correct format check
15820a9 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@degenaro
fix: rephrase login options
eae3ab3 
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
@degenaro degenaro merged commit 53d7fd4 into develop Feb 16, 2024
15 checks passed
@degenaro degenaro deleted the fix/community-call branch February 16, 2024 21:18
@degenaro degenaro mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpower432 jpower432 jpower432 approved these changes

@AleJo2995 AleJo2995 AleJo2995 approved these changes

@mrgadgil mrgadgil mrgadgil approved these changes

@vikas-agarwal76 vikas-agarwal76 Awaiting requested review from vikas-agarwal76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@degenaro @AleJo2995 @mrgadgil @jpower432