You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
where JuliaMatrixInt really is the Julia type Matrix{Int}.
I think that was a mistake. We probably should be using Matrix{Rational{BigInt}}. Because JConvex then often proceeds with code like this:
# sometimes, Polymake returns rational rays - we turn them into integral vectors
scaled_rays :=[];
for i in[1.. Length( rays ) ]do
scale := Lcm( List( rays[ i ], r -> DenominatorRat( r ) ) );
Append( scaled_rays, [ scale * rays[ i ]] );
od;
From @lkastner I learned that one can let Polymake do this scaling, by calling Polymake.common.primitive. So perhaps even better would be to replace all that scaling code by something like that (note the use of a to-be-defined JuliaMatrixBigInt):
When I refactored JConvex, I replaced code like this:
by stuff like this:
where
JuliaMatrixInt
really is the Julia typeMatrix{Int}
.I think that was a mistake. We probably should be using
Matrix{Rational{BigInt}}
. Because JConvex then often proceeds with code like this:From @lkastner I learned that one can let Polymake do this scaling, by calling
Polymake.common.primitive
. So perhaps even better would be to replace all that scaling code by something like that (note the use of a to-be-definedJuliaMatrixBigInt
):and then `scaled_rays is superfluous.
The text was updated successfully, but these errors were encountered: